Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add service for setting announce volume #78

Merged
merged 6 commits into from
Nov 21, 2023
Merged

feat: add service for setting announce volume #78

merged 6 commits into from
Nov 21, 2023

Conversation

eyr1n
Copy link
Member

@eyr1n eyr1n commented Sep 13, 2023

Related Issue(required)

Description(required)

feat: add service for setting announce volume

Review Procedure(required)

  • check if the volume changes with the following command(please use tier4_hmi_msgs in feat/announce_volume_srv branch)
ros2 service call /signage/volume tier4_hmi_msgs/srv/Volume "{volume: 0.5}"

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

@eyr1n eyr1n requested review from yabuta and tkhmy September 13, 2023 00:33
@tkhmy
Copy link
Contributor

tkhmy commented Oct 30, 2023

@eyr1n Do you store the sound volume after the sound is setted?
Because each time the ecu restart, we will need to set the sound volume again

@eyr1n
Copy link
Member Author

eyr1n commented Oct 31, 2023 •
edited
Loading

@tkhmy I will fix to store the volume in the node.
But how do I reset the volume when the ecu is restarted?

@tkhmy
Copy link
Contributor

tkhmy commented Oct 31, 2023

@tkhmy I will fix to store the volume in the node. But how do I reset the volume when the ecu is restarted?

@eyr1n you can just call the set volume function in the init function

tkhmy
tkhmy approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@tkhmy tkhmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eyr1n eyr1n merged commit 6d517aa into develop Nov 21, 2023
1 of 2 checks passed
@yabuta yabuta deleted the feat/set_volume branch February 29, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hidenaga41 Hidenaga41 Hidenaga41 left review comments

@tkhmy tkhmy tkhmy approved these changes

@yabuta yabuta Awaiting requested review from yabuta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eyr1n @tkhmy @Hidenaga41